[Freeciv-Dev] Re: [PATCH] Formatting cleanup.

[Jason Dorje Short <vze2zq63@xxxxxxxxxxx>]

Gaute B Strokkenes wrote:
> 
> On Fri, 12 Oct 2001, rwetmore@xxxxxxxxxxxx wrote:
> > At 12:43 AM 01/10/10 +0100, Gaute B Strokkenes wrote:
> >>On Mon, 8 Oct 2001, rp@xxxxxxxxxx wrote:
> >>
> >>> As a bystander I would like to say that it is still unclear to me
> >>> what an 'unreal' coordinate is supposed to be, and yes I do try to
> >>> follow the whole thread.
> >>
> >>Look at is_real_tile() in map.c.  It's a bit of a misnomer since it
> >>takes a pairt x, y as its argument rather than a tile pointer, but
> >>there you are.
> >>
> >>Basically a real coordinate pair is one that refers to an actual,
> >>on-map tile.  An unreal pair is one that does not.
> >
> > Completely wrong, Gaute. Or at best completely ambiguous.
> 
> Boggle.
> 
> > And you picked a bad example (try one that is at the left wrapwall
> > instead) to actually show what the real difference is.
> 
> Perhaps you could tell us what you think it ought to mean?
> 
> > Until you can clearly pinpoint what a real tile is, you will
> > continue to fall into the same pit that Freeciv void_tile and other
> > hacks left in the code when they tried to "fix" problems by breaking
> > things with for example the map_adjust_y() bug.
> 
> Balderdash.

I don't doubt that you know what a "real" tile is, but saying it "refers
to an actual, on-map tile" is misleading or perhaps even incorrect.  The
"map" is a map.xsize x map.ysize array, and a "tile" is an element in/on
the map.  So you could argue that only normal (proper) positions refer
to on-map tiles.

In summary, it's a bad example.

jason