[Freeciv-Dev] Re: [PATCH] Formatting cleanup.

[Gaute B Strokkenes <gs234@xxxxxxxxx>]

On Fri, 5 Oct 2001, hawk@xxxxxxxxxxxxxxxxxxxxxxx wrote:
> On Fri, Oct 05, 2001 at 10:19:04PM +0100, Gaute B Strokkenes wrote:
>> On Thu, 04 Oct 2001, vze2zq63@xxxxxxxxxxx wrote:
>> 
>> A good first step would be to convert as many places as possible to
>> use MAPSTEP() rather than manually twiddling coordinate pairs and
>> relying on normalize_map_pos() to clean up the mess.
> 
> I think we got everything. There are only some map_adjusts left:
> ./common/map.h:2
> ./server/mapgen.c:6
> ./server/maphand.c:1
> ./server/settlers.c:2
> ./server/unittools.c:1
> 
> If you know any more instances please tell.

There's lots in the client directories, but that might not be so
important.  I was just making a general point.

>> I'm not entirely sure what you mean by "converting it to a real
>> coordinate".  I assume you mean something like map_adjust_y() or
>> nearest_real_pos().  If you wish to take most abstract view
>> possible, this is more wrong
> 
>> than playing games with unreal coordinates
> 
> I agree that I think nearest_real_pos is a band-aid.

That's not what I'm saying.  I'm saying that it can not be generalised
to any and all topologies.  Whether we are interested in any where you
can not is another matter; I think the answer is no.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
The LOGARITHM of an ISOSCELES TRIANGLE is TUESDAY WELD!!