[Freeciv-Dev] Re: [Patch] is_city_center

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

You propagated the bug Gaute introduced in the assignment of pollution. 
Note, the original code skips on bad squares (preserving probabilities 
on a per square basis).

I would also seriously consider making this a macro before you add
this many extra function calls. At least profile it to justify the
loss of potential optimizations in surrounding code.

Many of them may actually be removed by using the appropriate city
iterator and/or cleaning up the code.

Cheers,
RossW
=====

At 12:54 PM 01/10/01 +0200, Raimar Falke wrote:
>
>The attached patch introduces a new method is_city_center. It also
>removes the local_ prefix of common/city methods.
>
>check_pollution in server/cityturn.c may need some extra eye balls.
>
>       Raimar
>
>-- 
> email: rf13@xxxxxxxxxxxxxxxxx
>  A supercomputer is a computer running an endless loop in just a second
>
>Attachment Converted: "c:\program files\eudora\attach\city_center1.diff"