[Freeciv-Dev] Re: [Patch] Extended connect dialog (PR#977)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Sep 24, 2001 at 09:27:16PM +0200, Andreas Kemnade wrote:
Content-Description: message body text
> Raimar Falke writes:
>  > On Mon, Sep 24, 2001 at 05:52:57AM -0700, Andreas Kemnade wrote:
>  > 
>  > It produces compiler warnings:
>  > 
> Fixed. The core dump is also fixed. But you can crash the client if you
> close the dialog and select the "Disconnect" menu item. But what
> should happen if you close the dialog:
> Quit the client?
> Popup the normal connect dialog?
> 
> The things on the todo list have still to be done.
> 
> The updated patch is attached.
> Of course, it is not ready for cvs.
> 
> Are the label texts good or could there be more meaningful text?
> What about the server window? More buttons?

Overall: very nice.

Problems:
 - it starts the civserver from "/usr/local/bin/civserver" which is
 old. It should try to start "./ser" or "./server/civserver" first
 - it looks like the client doesn't catch the error message of the
 server that the server can't bind to the default port. This should
 disable the start-game button.
 - I had to manually kill the civserver process. All sensible exits
 from the client (maybe not assert and abort but exit(0)) should popup
 a "Do you want to kill the server?" dialog.
 - after I press "end game" on the server window the main menu (the one
 containing new-game, load-game, join-game) reopenes. This should make
 the server window disabled.
 - can you add a "Quit game" button to the main menu?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  +#if defined(__alpha__) && defined(CONFIG_PCI)
  +       /*
  +        * The meaning of life, the universe, and everything. Plus
  +        * this makes the year come out right.
  +        */
  +       year -= 42;
  +#endif
    -- Patch for 1.3.2 (kernel/time.c) from Marcus Meissner