[Freeciv-Dev] Re: [patch] clause_list speclist

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Sep 19, 2001 at 10:36:03AM -0400, Justin Moore wrote:
> 
> > > +  struct city *pcity;
> >
> > > -    for (;ITERATOR_PTR(myiter); ITERATOR_NEXT(myiter)) {
> > > -      struct Clause *pclause = (struct Clause *)ITERATOR_PTR(myiter);
> > > -      struct city *pcity;
> > > -
> > > +    clause_list_iterate(ptreaty->clauses, pclause) {
> >
> > IMHO variables should be declared in the most inner scope to prevent a
> > pollution of the namespace.
> 
>    I moved it up to a higher scope because it was used within several
> different loops.  I figured it would just be easier to have it up here.
> *shrug*  Whatever.  New patch is attached.

You forgot some instances in the various client/*/diplodlg. Can you
add them?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Tank: So what do you need? Besides a miracle.
  Neo: Guns. Lots of guns.
    -- From The Matrix