[Freeciv-Dev] Re: [patch] clause_list speclist

[Justin Moore <justin@xxxxxxxxxxx>]

> > +  struct city *pcity;
>
> > -    for (;ITERATOR_PTR(myiter); ITERATOR_NEXT(myiter)) {
> > -      struct Clause *pclause = (struct Clause *)ITERATOR_PTR(myiter);
> > -      struct city *pcity;
> > -
> > +    clause_list_iterate(ptreaty->clauses, pclause) {
>
> IMHO variables should be declared in the most inner scope to prevent a
> pollution of the namespace.

   I moved it up to a higher scope because it was used within several
different loops.  I figured it would just be easier to have it up here.
*shrug*  Whatever.  New patch is attached.

-jdm

Department of Computer Science, Duke University, Durham, NC 27708-0129
Email:  justin@xxxxxxxxxxx

clause_list.patch
Description: Text document