[Freeciv-Dev] Re: Unused field in move_cost_map removed.

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Sep 18, 2001 at 01:51:21PM +0100, Gregory Berkolaiko wrote:
>  --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote: 
> > On Tue, Sep 18, 2001 at 12:39:32PM +0100, Gregory Berkolaiko wrote:
> > 
> > I looks like I miss something here: returned is malloc'ed, memset'ed
> > and tested but NEVER set. So the this variable is useless. If you also
> > come to this conclusion I don't understand why you made test runs?
> 
> To see if maybe correct usage of this field gives better performance.
> 
> > So what you think is the correct usage of this field?
> 
> to set it ;) when you return a location; see the attached patch (please
> DO NOT apply it)
> 
> > > "returned" field.  The savegames from the runs were identical in all
> > > cases 
> > > (expected)
> > 
> > You mention above that such "occurence is quite rare".
> 
> Yes, and even if it happens, the returned location is processed but
> nothing is actually changed.  It happens mostly on land, when a "longer"
> route is cheaper in movepoints.  Such location goes into queue twice (or
> more) but the cheaper route gets out of the queue first anyway.

Thue confirmed that this was the original intention. Still the number
I get from you aren't clear. How many times is this shortcut taken? 
From how many times in total? Also can you try the attached shell
script? This gives at least for me constant user times.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Understanding is a three-edged sword; 
  your side, their side, and the truth."
    -- a well-known Vorlon