[Freeciv-Dev] Re: [PATCH] Re: {gen,spec,sort}list stuff

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Sep 18, 2001 at 09:20:23AM -0400, Justin Moore wrote:
> 
> > >    I've saved you some of the trouble.  I made the changes myself and ran
> > > the tests.  The results were ... odd.  And somewhat disappointing.  I ran
> > > the test (same codebase) on three different machines.
> > >
> > > CPU/Mem      DLL(s)    Array(s)  Speedup(%)
> > > 486-66/32     7382      7259       ~2
> > > PII-300/128   579.1       579.2     none
> > > AMD-1200/900  236.7     246.8      ~4
> > >
> > >    These were all-AI games with the same .civserverrc on each.  Each was
> > > done with a 'make clean && make' at the top-level to ensure a complete
> > > switch from one to the other.  Each version was run ten times, the high
> > > and low times thrown out, then an average of each.
> >
> > > Approximately 80% of the old style iterators were converted to the
> > > array lists.
> >
> > The question is: are these converted iterators the "high volume"
> > ones?! You have to find iterations which are used a lot.
> 
>    Sorry, should have chosen better words.
> 
> Test         # of "genlist_iterator_init" calls
> linked list    133926755
> array           10080001
> 
>    Looks like 92.5% of the old iterators are gone.

What about the number of SAFE_TYPED_LIST_ITERATE executions vs
STABLE_TYPED_LIST_ITERATE executions? You can measure them with two
global variables.

> > Before you stop this please post the code.
> 
>    Here's the genlist stuff itself.  If you want everything -- including
> the changes to the rest of the tree -- that could take a while since that
> devel tree is about two weeks old and would need to be merged with the
> current CVS.

Can you please measure the above mentioned? I still think that the
idea is good. I'm trying to find why you don't see the expected
performance gain.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Sit, disk, sit. Good boy. Now spin up. Very good. Here's a netscape
  cookie for you. Fetch me some data. Come on, you can do it. No, not that
  data. Bad disk. Bad." 
    -- Calle Dybedahl, alt.sysadmin.recovery