[Freeciv-Dev] Re: the directional system

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 02:06 PM 01/09/07 +0200, Raimar Falke wrote:
>On Fri, Sep 07, 2001 at 06:59:52AM -0400, Jason Dorje Short wrote:
>DIR_DX2 is only used in
>client/tilespec.c:fill_tile_sprite_array_iso. Correct? Looking at it,
>it looks save for me to change the underlying direction
>system. Somebody has said that the graphics also depend on the
>direction system. It looks to me that the graphics only depend on
>INDEX_NSEW. Correct?

The GUI *NEVER* depended on the DIR_DX arrays or core system until
Jason's patch in August linked them. There should be *NO* references
to it in the GUI wihtout this.

But the GUI *DOES* depend on the array ordering of graphics elements,
and while I am certainly not 100% sure this is terminal, think that 
someone knowledgable should look down where the graphics data is read 
off the disk and first massaged. There are explicit and implicit things 
that depend on array order.

*DO* *NOT* make foolish comments or assumptions that a coarse tool like
grep is going to tell you all you want to know.

>$ grep -Ir DIR_DX .|grep -v DIR_DX2|grep -v CAR_DIR_DX|cut -d":" -f1|uniq -c
>      2 ./ChangeLog
>      1 ./client/goto.c
>      6 ./client/gui-gtk/mapview.c
>      2 ./client/gui-mui/graphics.c
>      4 ./client/gui-mui/mapclass.c
>      6 ./client/gui-win32/mapview.c
>      3 ./client/gui-xaw/mapview.c
>      6 ./common/map.c
>      5 ./common/map.h
>     14 ./server/gotohand.c
[...]
>The other changes look ok for me (I'm not very deep into this). 

That is true. Take it for a warning.

>       Raimar
>--