Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2001:
[Freeciv-Dev] Re: [PATCH] Corecleanup_07Part2 has been put in incoming
Home

[Freeciv-Dev] Re: [PATCH] Corecleanup_07Part2 has been put in incoming

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Gaute B Strokkenes <gs234@xxxxxxxxx>
Cc: jdorje@xxxxxxxxxxxxxxxxxxxxx, freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] Corecleanup_07Part2 has been put in incoming
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 2 Sep 2001 23:52:45 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Sun, Sep 02, 2001 at 11:32:01PM +0200, Gaute B Strokkenes wrote:
> 
> >> > I will not rearrange the _end macro by hand after an indent run
> >> > over a code section.
> >> 
> >> What's your point?
> > 
> > I run indent over all sections I change before I commit a patch.
> 
> Personally I prefer to make a unified diff and inspect it, rather than
> going with indent blindly.  But in any case:
> 
> donald:~$ cat > test.c
> int foo(int a)
> {
>   adjc_iterate(x, y, x1, y1) {
>     a++;
>   } adjc_iterate_end;
> }
> donald:~$ indent -kr -i2 test.c
> donald:~$ cat test.c
> int foo(int a)
> {
>   adjc_iterate(x, y, x1, y1) {
>     a++;
>   } adjc_iterate_end;
> }
> donald:~$ indent --version
> GNU indent 2.2.6
> 
> Does your indent do something else?

No. *checking* Mhh since I indent the lines which a patch touches with
my self written emacs macro. This macro feeds things like 

------
{{
  adjc_iterate(x, y, x1, y1) {
    a++;
  } adjc_iterate_end;
------

to indent. Yes this is my fault but I see no other way of easily
formatting changes.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "There are three ways to get something done. Do it yourself, hire someone
  to do it for you or forbid your kids to do it."


[Prev in Thread] Current Thread [Next in Thread]