[Freeciv-Dev] Re: [PATCH] Corecleanup_07Part2 has been put in incoming

[Trent Piepho <xyzzy@xxxxxxxxxxxxx>]

On Mon, 3 Sep 2001, Raimar Falke wrote:
> > That's what I do.
> 
> Ok we had this discussion:
>  - my personal style is another. I won't change it. I find it
>  convenient to just run indent of it and the changes are polished.

My personal style is different too.  But when I write for another project I
change to keep consistent.  Maybe you aren't flexible enough and should
consider working on that.

>  - for patches by other people I don't have to require proper
>  formatting

You just fix it yourself by hand.  In fact I would apply other's patches by
hand so I would be sure that I looked at everything going in.

> 
> > And when I commited patches, I would compile them and test them first.  If 
> > you
> > look at the beginning of the change log, you will see hundreds of commits by
> > me but no corrections the next day because my commit caused the server to
> > crash.
> 
> People want more experimental stuff in the tree. People want more
> tested stuff in the tree. Do you see the problem I have.

I think if you asked the hundreds of people who aactually play the game, they
won't tell you that they want the server to crash more aften, the client to
get even slower, and modem players to be excluded out right.  The people who
want "experimental" stuff are people who want their own pet projects in and
can't be bother to do them right, or even accept the fact that their idea is
stupid and no one else wants it.