[Freeciv-Dev] Re: Minor text bug in help

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Aug 30, 2001 at 09:14:05PM +0100, Jules Bean wrote:
> On Thu, Aug 30, 2001 at 10:06:12PM +0200, Raimar Falke wrote:
> > On Thu, Aug 30, 2001 at 08:47:35PM +0100, Jules Bean wrote:
> > > A debian user has pointed out that the help for the manhattan project
> > > is doubled up, as it were.
> > > 
> > > See http://bugs.debian.org/108385
> > 
> > The strings in the data file (also in the old (1.18)) are
> > correct. Either there is a bug somewhere in freeciv which doubles the
> > string or it is some display error.
> > 
> > Can some debian user install this version and verify this?
> 
> Weird.
> 
> I can verify it in 1.12 here (the debian package of 1.12, that is).  I
> wouldn't have forwarded the bug without checking it first.

I'm sorry I just looked at the data files and haven't tested it. I
really didn't expect what I found. From
client/helpdata.c:helptext_wonder():

  if(which==B_MANHATTEN && num_role_units(F_NUCLEAR)>0) {
    int u, t;
    u = get_role_unit(F_NUCLEAR, 0);
    assert(u<game.num_unit_types);
    t = get_unit_type(u)->tech_requirement;
    assert(t<game.num_tech_types);
    sprintf(buf+strlen(buf),
           _("Allows all players with knowledge of %s to build %s units.  "),
           advances[t].name, get_unit_type(u)->name);
  }

This special code is there since the start of the cvs. The normal help
text got included here:

----------------------------
revision 1.13
date: 2000/05/24 19:13:04;  author: jjm;  state: Exp;  lines: +1539 -621
Generalized Improvements, first phase.
This adds new fields to the buildings.ruleset files; adds the code to
parse these fields, store and transmit them to the client.  So far, none
of this new information is used, and this patch should have no affect on
the existing game.
Partial fix for PR#243.
Patch submitted by IQ <iquin@xxxxxxxxxxxxxxxx>,
with re-engineering by me.
----------------------------

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "SIGDANGER - The System is likely to crash soon"