[Freeciv-Dev] Re: [PATCH] city_map_size fix and idea

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

The ugliness aspect is handled by other changes such as using 
city_map_iterate_checked(). The current code if you will note does
not check that the city_map location is actually on the real map
when it uses such things.

The change to use CITY_MAP_SIZE/2 is one of those "good" things 
that you don't want to kill for perfection. They used to hard coded
magic numbers, and someone actually started to propagate this awhile
back. By the time you get through the 06b,c changes most of the
magic numbers should be gone. Please, don't put them back :-).

Cheers,
RossW
=====

At 05:02 PM 01/08/22 +0200, Raimar Falke wrote:
[...]
>For me the primary goal isn't to enable to code to has a changeable
>CITY_SIZE but currently just code cleanup. "pcity->x + x +
>CITY_MAP_SIZE/2" is just dead ugly. A transformation method would be
>nice something with more a abstract numbering even better.
>
>       Raimar
>-- 
> email: rf13@xxxxxxxxxxxxxxxxx
> "Using only the operating-system that came with your computer is just
>  like only playing the demo-disc that came with your CD-player."