[Freeciv-Dev] Re: [PATCH] city_map_size fix and idea

[Trent Piepho <xyzzy@xxxxxxxxxxxxx>]

On Wed, 22 Aug 2001, Ross W. Wetmore wrote:
> 
> The iterator is cartesian_adjacent_iterate_dir() but the "dir" flavours
> are still controversial, so aren't yet available.

That isn't a consistent name with the other iterators.  They all end in
_iterate.  Also adj_iterate has been there for a long time, no need to spell
out adjacent.

> But I wish you wouldn't pop out the switch hack every time though. 
> Functional code flow as oppposed to data driven techniques is going
> to proliferate a lot of stuff like this throughout the code that
> if you ever *do* need to change is going to be another core cleanup. :-)

If you don't like a switch statement, what would you do?  Something that
doesn't depend on any magic numbers.