[Freeciv-Dev] Re: Pop cost patch (resending via bug system) (PR#897)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Aug 22, 2001 at 09:48:05AM -0700, Arien Malec wrote:
> 
> --- Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx> wrote:
> > > -int can_unit_add_to_city(struct unit *punit)
> > > +enum add_to_city_status unit_add_to_city_status (struct unit *punit)
> > 
> > What do think about {general,basic}_unit_add_to_city?
> 
> I think that implies that you are actually adding to the city, whereas you 
> want
> to know if you can, and if you can't, why...

Ok.

> It's obnoxiously long, but unit_add_to_city_attempt_result gets the idea
> across. I'l work on the extended patch to cleanup handle.... since changing 
> the
> function name is easy.

What about just changing the result type of can_unit_add_to_city? Like
can_unit_move_to_tile_with_reason?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  The trick is to keep breathing.