[Freeciv-Dev] Re: [PATCH] is_normal_tile function

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Gaute B Strokkenes <gs234@xxxxxxxxx> wrote: 
> 
> Also, this patch is IMHO wrong.  A tile such as (4, -1) is, in the way
> that I see things, normalised but not real.  A better name for this
> function would be is_proper_tile().
> 

There are many ways to reference a tile in the cylindrical world but
there is only one normal form (or canonical form, but not "proper" form),
the one where 0 <= x < xsize and 0 <= y < ysize.  Thus is_normal_tile is
the right name.

The coordinates (4,-1) are not in normal form and are not even normalisable.

____________________________________________________________
Do You Yahoo!?
Get your free @yahoo.co.uk address at http://mail.yahoo.co.uk
or your free @yahoo.ie address at http://mail.yahoo.ie