Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: [PATCH] is_normal_tile function 		Home

[Freeciv-Dev] Re: [PATCH] is_normal_tile function

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Jason Dorje Short <jshort@xxxxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] is_normal_tile function
From: Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>
Date: Wed, 15 Aug 2001 21:41:17 +0100 (BST) 
 --- Jason Dorje Short <jshort@xxxxxxxxxxxxx> wrote: 
> +***************************************************************/
> +int is_normal_tile(int x, int y)
> +{
> +  return 0 <= y && y < map.ysize && 0 <= x && x < map.xsize;
> +}

you might want to use Ross' geeky way of writing such things:

return ((unsigned) y < (unsigned) map.ysize) && (....)

or am I as usual missing something?

G.

____________________________________________________________
Do You Yahoo!?
Get your free @yahoo.co.uk address at http://mail.yahoo.co.uk
or your free @yahoo.ie address at http://mail.yahoo.ie
[Prev in Thread] Current Thread [Next in Thread]