Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: [PATCH] is_normal_tile function
Home

[Freeciv-Dev] Re: [PATCH] is_normal_tile function

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] is_normal_tile function
From: Jason Dorje Short <jshort@xxxxxxxxxxxxx>
Date: Thu, 16 Aug 2001 01:55:29 -0400

Raimar Falke wrote:
> 
> On Wed, Aug 15, 2001 at 04:14:32PM -0400, Jason Dorje Short wrote:
> > The attached patch introduces a new function, is_normal_tile, that
> > behaves as you would expect it.  It does not change any existing code to
> > use the new function - there's a _lot_ of places where it should be
> > used, and some of them would no doubt be controversial.  Easier to worry
> > about that once the function's already in CVS.
> 
> I don't know what is the status of the patches Ross and the others
> have supplied. Some part was applied before 1.12.0. A big chunk is
> still floating around. You have to check if some of your work overlap.

I haven't looked at those patch(es) as closely as I should have, but I
don't believe they include the equivalent of is_normal_tile.  If they
do, I believe this part can be separated out and stand as a patch on its
own (we were trying to break down those patches, right?).

BTW, I believe the part "applied before 1.12.0" you're referring to is
probably the adjc_dir_iterate macro, which wasn't a part of the map core
code patch (though closely related).

jason


[Prev in Thread] Current Thread [Next in Thread]