Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: [PATCH] directional code cleanup: patch #1 		Home

[Freeciv-Dev] Re: [PATCH] directional code cleanup: patch #1

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Jason Dorje Short <jshort@xxxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] directional code cleanup: patch #1
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 15 Aug 2001 22:30:41 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx 
On Wed, Aug 15, 2001 at 04:04:32PM -0400, Jason Dorje Short wrote:
> > 
> +typedef enum direction8 Direction8;

Mhh there are only 3 typedef of enums in the code. Since also the rest
of the code uses typedefs only sparsely I would suggest removing it.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "Heuer's Law: Any feature is a bug unless it can be turned off."
[Prev in Thread] Current Thread [Next in Thread]