Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: [PATCH] directional code cleanup: patch #1 		Home

[Freeciv-Dev] Re: [PATCH] directional code cleanup: patch #1

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Jason Dorje Short <jshort@xxxxxxxxxxxxx>
Cc: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] directional code cleanup: patch #1
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 15 Aug 2001 21:15:03 +0200
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx 
On Wed, Aug 15, 2001 at 02:02:41PM -0400, Jason Dorje Short wrote:
> Third (possibly final) patch attached.

Surprisingly I found another one ;)

> +enum {

Could this be named "enum direction8" or something like this.

> +  /* FIXME: DIR8 is used to avoid conflict with another enum */

Which one?

> +const char* dir_get_name(int dir)

const char* dir_get_name(enum direction8 dir)


        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Only one human captain has ever survived battle with the Minbari
  fleet. He is behind me. You are in front of me. If you value your 
  lives, be somewhere else."
    -- Ambassador Delenn, "Severed Dreams," Babylon 5
[Prev in Thread] Current Thread [Next in Thread]