[Freeciv-Dev] Re: [PATCH] directional code cleanup: patch #1

[Gregory Berkolaiko <gberkolaiko@xxxxxxxxxxx>]

 --- Jason Dorje Short <jshort@xxxxxxxxxxxxx> wrote: 
> > Compare
> > freelog(LOG_NORMAL, "direction of next step is %s",DIR_NAMES[dir]);
> > with
> > freelog(LOG_NORMAL, "direction of next step is
%s",get_dir_name(dir));
> 
> Okay - although I don't think it really looks nicer, having extra
> checks in the function is nice.

how about a macro?  it's faster than function and you can put checks
there too, although you'll have to forgo type checking.

as for the looks, I think both are aesthetically pleasing :)

G.

____________________________________________________________
Do You Yahoo!?
Get your free @yahoo.co.uk address at http://mail.yahoo.co.uk
or your free @yahoo.ie address at http://mail.yahoo.ie