[Freeciv-Dev] [PATCH-Review] directional code cleanup: patch #1

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

At 07:08 PM 01/08/17 -0700, Trent Piepho wrote:
>On Fri, 17 Aug 2001, Jason Dorje Short wrote:
>> > 
>> > The fifth and hopefully final version of this mini-patch is attached.
>> 
>> Doh!  Now it's attached.
>
>Looks good to me.  The IS_xxx macro names are longer than I would have used,
>but that's just personal preference.  If freeciv was still on the
>ultraviolet.org cvs repository I would apply it.

I like this kind of posting. 

It provides good timely feedback to someone who has submitted something, it
tells the rest of the community that this has been looked at or tried or
whatever and passes review. And it doesn't put a lot of load on those that
are doing other things for the project.

If a couple of these came out, for each patch from those working or
knowledgable about the area, I think we'd have a defacto peer review system.

And, as I have pretty much the same changes, I can second the review that
they are all quite adequate and consise at fixing the underlying problems.

Cheers,
RossW