[Freeciv-Dev] Re: Sound patches please add to CVS

[David Weisgerber <tnt@xxxxxxxxx>]

> You will probably play it when the move animation is shown:
> client/*/mapview.c:move_unit_map_canvas.

There are no problems with unit moving sounds, I was able to implement this 
to packhand.c

> You have to think about this. One solution is the play sounds only if
> the action takes place at the currently viewed section of the map and
> omitt the sound at the start of the turn.

Hmm... well I look what I can do

> > What sounds are played is declared in sound.h in a const struct, please
> > search for the right sounds you want to have played. I weren't able to
> > find some cool which would fit. Later I will change the code to add an
> > option to parse it from a config file like the tile sets...
>
> You have to supply the sounds IMHO.

I have found some great sounds, I will supply a patch with them later...

> > Please edit the configure file to include sound.c. It must be compiled
> > like control.c so it just some copy & paste to do. Have thanks...
>
> Please change Makefile.am and send the changes as a diff.

I am looking forward to get my CVS running and I will later submit the patches

> > The whole thing only depends on "play", but maybe I will write a routine
> > for output via ALSA or OSS.
> >
> > CU,
> > David
> >
> > PS: Please comment what I did!!! And by the way, change the wave files
> > which I included in sound.h...
>
> Please change
>  /* Sound Magics */
>  #define SOUND_LOW_ON_FOUNDS 0
>  #define SOUND_POLLUTION 1
> to an enumeration.
>
>       Raimar

Ok, I will do so...

Have thx,
David

-- 
Hin und wieder erhält man unter Windows Fehlermeldungen, die mit
"Unerwarteter Fehler" beginnen.  Sollte man daraus schließen, daß es
auch "erwartete Fehler" gibt, die dann hämisch mit: "Hab ich´s mir
doch gedacht, daß Du mal auf diesen Fehler stoßen wirst.  Früher oder
später kriegen wir Dich doch." eingeleitet werden?