[Freeciv-Dev] Re: readline 4.2

[Thue <thue@xxxxxxx>]

On Tuesday 10 April 2001 14:49, Erik Sigra wrote:
> tisdagen den 10 april 2001 13:56 skrev Thue:
> > On Tuesday 10 April 2001 13:45, Thue wrote:
> > > readline 4.2 was released recently, and it breaks freeciv readline
> > > support horribly. Here is a kludge to fix it, see comments in patch.
> > >
> > > I didn't test it with 4.1 or earlier as it is a bit of a pain to
> > > downgrade stuff like that. Could someone please try it?
> > >
> > > -Thue
> >
> > On second though this will only work with the version of readline with
> > which it was compiled. Why do the readline folks feel they need to change
> > their interfaces...
>
> Just let Freeciv depend on readline-4.2 or higher for readline
> functionality. It is generally better style for a program to require
> current libraries than legacy libraries.
>
> About the patch: It doesn't change anything related to configure, so it is
> not even possible to configure to use readline-4.2, so I don't know if the
> actual code changes would work.

What the patch does is to check for a define only set in 4.2, and define the 
name of a readline function according to that. That should work, no? At least 
it works on my system with readline 4.2, and I would really like someone with 
readline <= 4.1 to test it. :)

-Thue