[Freeciv-Dev] Re: flooded towns (PR#675)

[Thue <thue@xxxxxxx>]

On Tuesday 13 February 2001 13:40, Christian Knoke wrote:
> Reinier Post wrote:
> > On Mon, Feb 12, 2001 at 03:33:14PM -0800, Christian Knoke wrote:
> >
> > [upon dissolving London while trunign it into swamp]
> >
> > > The submarine is caught in London, not transferred to the
> > > ocean as it should be.
> >
> > Why should it be?  If players aren't smart enough to move their
> > boats to sea isn't it more logical to just ground them?
>
> Maybe because you can attack with those grounded ships
> (of course not with submarines, but with cruisers) and
> get attacked by land troups (also submarines)? Because
> they impose a ZOC? With a submarine, you can even have
> cruise missiles there :-)
>
> > --
> > Reinier
>
> Christian

With this patch sea units are moved out of the city when the city is 
disbanded. If they can't they are wiped.
I had to clean up could_unit_move_to_tile() to make the patch.
While making the patch I noticed some wrong messages generated by 
transfer_city_units(), so I fixed those too and cleaned up the func.
While testing my changes to transfer_city_units I noticed that when a 
diplomat incited a revolt it was first removed and then the city was 
transfered, meaning the area near the city was first fogged and then 
unfogged. So I changed it to transfer the city first and then move the 
diplomat.

-Thue

bugfixes.diff
Description: Text document