Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2001:
[Freeciv-Dev] Re: Extern declarations should be in .h file in client (PR 		Home

[Freeciv-Dev] Re: Extern declarations should be in .h file in client (PR

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Dirk Stoecker <stoecker@xxxxxxxxxxxxxx>, freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: Extern declarations should be in .h file in client (PR#676)
From: Thue <thue@xxxxxxx>
Date: Mon, 29 Jan 2001 19:56:52 +0100 
On Monday 29 January 2001 12:48, Dirk Stoecker wrote:
> Hi,
>
> > Right now the gui-gtk and gui-xaw client declare the variables they
> > import as extern inside the C file. It would be much nicer if these were
> > declared in the respective .h files and then .h files then included.
>
> Attached a fix for the GTK client. Also made some variables static and
> removed obsolete variables. As I saw, there is a lot more stuff, which
> could be static.
>
> It compiles fine under Suse Linux 6.4, but as Linux is not my master OS I
> cannot guarrantee :-)
> But it is that easy...

Thanks. Leaving the bug open as there is more stuff to fix.

-Thue
[Prev in Thread] Current Thread [Next in Thread]