Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2001:
[Freeciv-Dev] Re: Extern declarations should be in .h file in client
Home

[Freeciv-Dev] Re: Extern declarations should be in .h file in client

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: Extern declarations should be in .h file in client (PR#676)
From: Dirk Stoecker <stoecker@xxxxxxxxxxxxxx>
Date: Mon, 29 Jan 2001 12:48:23 +0100 (MET)
Reply-to: Dirk Stoecker <stoecker@xxxxxxxxxxxxxx>

Hi,

> Right now the gui-gtk and gui-xaw client declare the variables they import as 
> extern inside the C file. It would be much nicer if these were declared in 
> the respective .h files and then .h files then included.

Attached a fix for the GTK client. Also made some variables static and
removed obsolete variables. As I saw, there is a lot more stuff, which
could be static.

It compiles fine under Suse Linux 6.4, but as Linux is not my master OS I
cannot guarrantee :-)
But it is that easy...

Ciao
 ____  _ _  ____  _ _    _ _  ____
|    |  |  |    |  | \  / |  |    | the cool Gremlin from Bischofswerda
|  __   |   ____|  |  \/  |  |    | WWW: http://home.pages.de/~stoecker/
|    |  |  |       |      |  |    | PGP key available on www page.
|____| _|_ |____| _|_    _|_ |____| I hope AMIGA never ends to make fun!

Attachment: ExternFixGTK.diff.gz
Description: Binary data


[Prev in Thread] Current Thread [Next in Thread]