Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2001:
[Freeciv-Dev] Re: PATCH: new messages again
Home

[Freeciv-Dev] Re: PATCH: new messages again

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Tuomas Airaksinen <tuma@xxxxxxxxxxxx>, freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: PATCH: new messages again
From: Thue <thue@xxxxxxx>
Date: Sun, 21 Jan 2001 00:44:20 +0100

On Saturday 20 January 2001 22:16, Tuomas Airaksinen wrote:
> Argt, famine feared again because you don't apply _ready_
> patches!!!
>
> I think there were consensus that my warning patch were ready
> (no need for capability string ASO), so why can't you finally
> apply it!
>
> Those warnings are VITAL in every game, I think! Without them there
> happen many needle mistakes.
>
> So... I remind to apply it.

I took a better look and changed some things:
-Changed the old famine message from "famine feared" to "famine occured" and 
changed your new message to "famine feared".
-Reindented your patch. Either you do it or I have to do it, so please...
-Don't report (the new) "famine feared" unless city has negative 
food_surplus. (this may be controversial, but you generelly have too many 
cities with 0 food and no surplus)
-Capitalize the Client Message Options for Consistency
-Refrase the new government available message

(If you complain long enough that your patch should just be applied you can 
expect to have the errors spelled out :))

-Thue

Attachment: messages.diff
Description: Text Data


[Prev in Thread] Current Thread [Next in Thread]