Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2000:
[Freeciv-Dev] Re: [PATCH] gui-gtk transient windows
Home

[Freeciv-Dev] Re: [PATCH] gui-gtk transient windows

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: [PATCH] gui-gtk transient windows
From: Dennis Bjorklund <dennisb@xxxxxxxxxxxxxx>
Date: Sun, 2 Jul 2000 17:13:26 +0200 (MET DST)

On Sun, 2 Jul 2000, Mathias Hasselmann wrote:

> >>> The gtk gui does not set it's dialogs to transient which in many
> >>> window managers are required for correct behavior. I've made a patch
> >>> against 1.11.0. It's not the latest cvs but I hope it apply anyway.
> 
> Thanks! I still have not applied the patch, but probably 
> you saved me some time, since I was thinking about doing 
> this job :)

Well, you might want to wait with the patch. I havn't used freeciv that
much so I didn't realise that some of these windows should not really be
transient. You can very well play with some of these windows open all the
time. For example the messages window can be open all the time while
playing. Then it shouln't be marked transient.

The problem with the window manager (sawfish) is that before it saw all
the toplevel windows as beeing the same. That ment that it used the saved
size to set the initial size of the windows. And it used the same size for
all these windows which made some of them looks really stupid.

I guess that for the messages (and players, city) window we should
instead set some suitable window class properties so that the window 
manager understands that these are different toplevel windows.

Together with sawfish, civclient with my patch is still much better then
without it. But I dont think it's the right thing to do with other 
toplevel windows. That's what you get when you jump into a program and
starts patching directly.

/Dennis




[Prev in Thread] Current Thread [Next in Thread]