[Freeciv-Dev] Re: Units not shown when investigating city. (PR#422)

[Thue <thue@xxxxxxx>]

Den tir, 27 jun 2000 skrev Thue:
> Den tir, 27 jun 2000 skrev Jeff Mallatt:
> > At 2000/06/27 10:50 , Marko Lindqvist wrote:
> > >On Tue, 27 Jun 2000, Thue wrote:
> > >
> > >> Den tir, 27 jun 2000 skrev Marko Lindqvist:
> > >> > It seems related to whether city is fogged when turn starts or not.
> > 
> > It does seem to be related to fog -- if the city is fogged at the beginning
> > of the turn, units present in the city do not show up as present (or
> > supported, if they are supported from the city).
> > 
> > However, there is also a problem with units that are fogged at the moment
> > the city is investigated -- even if the city is not fogged at the start of
> > the turn, if a unit that is supported by the city is fogged when the city
> > is investigated, that unit does not show up as supported.
> 
> What happens is that when the diplomat dies you lose visibility of the
> square of the city, and the client automatically removes all units on the
> square.
> 
> I am still trying to find a way to get around it... I think it will require
> some changes which is not nice if freeciv is to be released tomorrow.
> I will send a first try at a patch shortly
> 
> -Thue

Here is a fix; it changes how FoW works in the client, so that units is
now removed when the tile becomes visible, not when it becomes fogged. As
far as I can see, and I *think* I can see it all, it doesn't have any
problems, but it is a bit fundamental! I haven't really tested it yet,
just thought about what needed to be changed.

Perhaps we should just list the bug in BUGS and apply the fix to the next
version.


It also has the consequence that cities remember their occupied flags, but
with 2 problems:
1) since the server currently sends remove_unit's to all players, the flag
will actually sometimes get updated, which is shouldn't. We could fix the
sending of remove units, but that is another change that should have
testing
2) the flags are not remembered over savegames or disconnect/reconnects.

We could just disable this

-Thue

diff
Description: Text Data