[Freeciv-Dev] Re: autosettler cleans pollution more

[Falk Hueffner <falk.hueffner@xxxxxxxxxxxxxxxxxxxxxxxx>]

Jeff Mallatt <jjm@xxxxxxxxxxxx> writes:

> At 2000/06/17 14:31 , Falk Hueffner wrote:
> >Jeff Mallatt <jjm@xxxxxxxxxxxx> writes:
> >
> >> This one-liner makes auto-settlers cleanup pollution more aggressively.  It
> >> should mitigate the multiple waves of global warming caused by AI players.
> >> [2 pollution-cleanup-0.diff <text/plain; us-ascii (7bit)>]
> >> diff -ru -X /home/jjm/cvs/no.freeciv FreecivCVS/server/settlers.c
> freeciv/server/settlers.c
> >> --- FreecivCVS/server/settlers.c   Wed Jun 14 10:48:37 2000
> >> +++ freeciv/server/settlers.c      Sat Jun 17 09:57:23 2000
> >> @@ -517,7 +517,7 @@
> >>    map_clear_special(x, y, S_POLLUTION);
> >>    m = city_tile_value(pcity, i, j, 0, 0);
> >>    map_set_special(x, y, S_POLLUTION);
> >> -  return(m);
> >> +  return(m * 4);  /* Pollution clean-up arbitrarily weighted more
> important. */
> >>  }
> >>  
> >>
> /**************************************************************************
> >
> >Are you sure m is never zero, for example when evaluating Arctic or
> >similar? I suggest you add one or similar, or just always return 1000
> >:)
> 
> When I looked at it, m seemed to range from about 50 to about 300, but I
> didn't look into what the actual full range would be.

From a quick look, it's something like 10*(food+prod+trade), so it
might be 0. So I suggest to simply return (m+100).

>> Also, I think the AI wouldn't cleanup pollution out of city radius,
>> but perhaps that is rather uncommon, so it doesn't really matter.
> 
> Pollution only happens within a city radius.
> 
> Except for pollution caused by being nuked.  However, I don't want
> the AIs to aggressively clean-up nuke pollution: a friend pointed
> out that making the AIs clean up nuke pollution makes nuking them a
> great way of wasting their Settlers/Engineers.  I don't want to make
> nukes attractive to use, so I'm thinking of adding a different kind
> of pollution, S_FALLOUT, that acts just like S_POLLUTION in game
> terms, but that the AI doesn't aggressively clean-up.

Hm, I'm not sure that's worth the trouble. To make nukes less
attractive, one could perhaps harm the reputation when using them.

        Falk