[Freeciv-Dev] Re: transform to/from ocean bug (patch)

[Thue Janus Kristensen <thue@xxxxxxx>]

> > Second, I did some "extreme terrain modification" testing.  I used my
> > favorite save-file (an all-AI game, saved in 4000BC), but I modified
> > terrain.ruleset to make changing land forms into Forest and into Swam and,
> > finally, into Ocean very cheap (I set them all to 1).  This resulted in
> > *many* "Get_def bugged" errors _even with this patch applied_ (and, this
> > patch is supposed to prevent these errors).
> 
> I'll have a look.
> 
> > jjm
> 
> -Thue

It turns out that the autosettlers doesn't use can_unit_do_activity().
Now they should be safe anyway.
Also, when doing global warming we now check the unit activity after
changing the terrain.
The problem with the transported_by id's is a minor one that can be
fixed later. This patch will still work reasonably without it.

-Thue

change_4.diff
Description: Text Data