[Freeciv-Dev] Re: Barbarian unleashing hanging server?

[Falk Hueffner <falk.hueffner@xxxxxxxxxxxxxxxxxxxxxxxx>]

Jeff Mallatt <jjm@xxxxxxxxxxxx> writes:

> [1  <text/plain; us-ascii (7bit)>]
> At 2000/01/10 14:16 , Falk Hueffner wrote:
> >I've had the server hang after entering a hut in the loop on line 265
> >in barbarian.c. Either the stack was corrupted and this is wrong
> >anyway (some variables have broken values, but this could be a bug of
> >gdb), but it seems the problem might be that the barbarians are being
> >moved out of the hut with handle_unit_move_request(), which check
> >ZOCs, and just aren't allowed to leave so it loops forever. Could
> >please somebody with some more knowledge on this part check that?
> 
> Yup, that's the problem.
> 
> And, well, this is an awfully klugey fix for this problem -- it does seem
> to get rid of the server hang.  Perhaps someone who has more knowledge of
> how movement works could supply a better solution?

Hm, this seems really ugly. It should really be possible to factor out
the needed parts (update position, inform players, anything else?) out of
handle_unit_move_request and call that in barbarian.c.

        Falk