[Freeciv-Dev] New Rapture_size in 1.9.0 (PR#194)

[mike_jing@xxxxxxxxx]

Full_Name: Mike Z. Jing
Version: 1.9.0
Distribution: Built from source
Client: Gtk+
OS: Linux (Redhat 6.0)
Submission from: (NULL) (128.59.42.58)


According to NEWS, Rapture_size is now 3 in 1.9.0, and in fact it works.
However, it might appear broken because the game message on celebrating 
cities does not appear for cities of size 3 or 4, while you can see they 
are actually in rapture because they do grow 1 size bigger after each 
turn under the right form of government.  The same problem exists in City 
Report, where cities of size 3 or 4 which should be in rapture are not 
indicated as such.  And finally, the in-game help on Happiness still says
Rapture_size is 5.  This is not a major problem but it did lead to some 
of my confusion over this issue.

As a side note, maybe we should add a celebration icon for cities in 
rapture?  Because cities in disorder are marked with a lightening bolt,
maybe we can add some fireworks or something for the celebrating cities.  
This is mostly cosmetics but it would be nice.

A more useful graphics addition would be, say, smoke for polluting cities 
(cities with pollution>0, not after the pollution has already affected
city quares) so that they are more visible.  For now the user has to check
the Demographic Report to see if there is any pollution, and it's hard to 
find which cities are actually producing it.  Also the amount of pollution 
of each city should be included in the City Report (F1).