Re: [Freeciv-Dev] Fundamentalism

[David Pfitzner <dwp@xxxxxxxxxxxxxx>]

Kris Bubendorfer wrote:

> Anyone remember what the title (king, Mr....) is used with Fundamentalism?
> 
> No I'm not adding it, but I want to fill in the array space where it goes, so 
> that my civil war stuff will not break if it does get implemented.

Doesn't adding the possibility for Fundamentalism mean changing 
the government enumerated type?  (I don't think its there now...?)

Which would be a protocol incompatibility since the client 
presumably uses it when selecting/displaying goverment etc.  
Adding Fundamentalism at the end of the enum would probably 
be least incompatible, but still a bit iffy because if the 
server started using it at some stage, then the client could 
run off the end of arrays etc.

I think adding Fundamentalism (even just to the enum) is a 
non-trivial exercise, so I wouldn't worry too much about 
associated breakages.  (I'd say a comment in the code would 
suffice.)

Regards,
-- David