[freeciv-ai] (PR#9247) cm shouldn't count waste as a good thing
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
|
To: |
undisclosed-recipients: ; |
|
Subject: |
[freeciv-ai] (PR#9247) cm shouldn't count waste as a good thing |
|
From: |
"Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx> |
|
Date: |
Fri, 16 Jul 2004 08:11:56 -0700 |
|
Reply-to: |
rt@xxxxxxxxxxx |
<URL: http://rt.freeciv.org/Ticket/Display.html?id=9247 >
> [bhudson - Tue Jul 13 22:44:19 2004]:
> Production is not used; it's not clear to me why the CM should care
> about it at all.
Agreed.
> While we're at removing things, we could remove the factor_target too,
> since (a) no code uses FT_EXTRA; (b) it shouldn't change the results
> anyway; (c) it does change the results because the current 'base = min -
> surplus' logic is wrong: higher surplus right now means lower score!
Agreed.
> Attached patch removes those and also merges some duplicated code
> between cm.c and cma_core.c (only that duplicated code that is
> affected).
I like the idea but the patch doesn't apply (conflicts in cm.c) and
doesn't compile (factor_target is still used in some of the GUI code).
It would also be nice to split it up into smaller patches, but that's
not strictly necessary.
jason
|
|
