[freeciv-ai] Re: uploaded new versions of teams and massive AI patches

[Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Wed, 16 Oct 2002, Per I. Mathisen wrote:

> On Thu, 17 Oct 2002, Raimar Falke wrote:
> > > I am afraid so. It is near impossible now to split it up back into its
> > > constituent patches. I've made so many interconnected changes.
> >
> > And splitting it again will clean the code up further. Trust me. It
> > will also force you to docment each change in more detail.
> 
> Perhaps it will. However, it will also force me to rewrite large parts of
> several of the patches from scratch.
> 
> That is _a lot_ of time and effort I would rather spend on pushing the
> cleanup further.
> 
> Many of the changes being done now are temporary. There is absolutely no
> reason to have a "do it perfectly" attitude to it. As Greg said, we have
> to break it a little before we can improve it.

I think there is a big difference in "do it perfectly" and "do it in a 
series of patches".  But if you lost track of the changes you do, I think 
it's wiser to commit it as a whole and then sort out the bugs.  None of 
this code should be "critical"...

In the future we should avoid doing this.  In particular, we can commit 
small changes faster, to avoid patch entanglement.

I'll try to make a patch of flying upgrades against massiveai.

G.