Complete.Org: Mailing Lists: Archives: freeciv-java: April 2002:
[FreeCiv-Java] Re: Contribution on Java-freeciv

[FreeCiv-Java] Re: Contribution on Java-freeciv

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: "Leprince Olivier" <leprinco@xxxxxxxx>, <freeciv-java@xxxxxxxxxxx>
Subject: [FreeCiv-Java] Re: Contribution on Java-freeciv
From: "Ben Hutchison" <ben.hutchison@xxxxxxxxxxxxxxx>
Date: Mon, 15 Apr 2002 10:01:44 +0100


I think the way arrow (move) keys are handled in the submitted patch may
cause some flexibility/extensiblity problems in the future.

It seemed that a move packet was constructed and dispatched to the server
from inside the key event handler. This would probably need to be changed
if/when other ways of moving are added (eg mouse click or scripting), if any
centralized logging/diagnostics were added, or if the user wished to remap

I think a public move() API that sent the move packet would limit these
problems. Then all client code that wished to move pieces can do so in a
uniform manner.


----- Original Message -----
From: "Leprince Olivier" <leprinco@xxxxxxxx>
To: <freeciv-java@xxxxxxxxxxx>
Sent: Thursday, April 11, 2002 5:25 PM
Subject: [FreeCiv-Java] Contribution on Java-freeciv

> Hello,
> I discovered a few weeks ago that the Java Freeciv
> project rebirthed from its ashes. I really desire
> to be involved in the new adventure even if, once
> again, the enthousiasm seems to be low.
> My name is Olivier and I am a french developper.
> As I am behind a proxy, I can't connect directly with
> the cvs-server, but I would like to submit patches to
> the project.
> Maybe someone could checkin my development for me in
> the CVS tree. The Zip file contains a diff file that
> should be apply on the cvs tree released on 02/04/2002
> and two new classes. Units may now move and the screen
> is updated when so.
> Thanks in advance.
> Olivier
> ___________________________________________________________
> Do You Yahoo!? -- Une adresse gratuite et en français !
> Yahoo! Mail :

[Prev in Thread] Current Thread [Next in Thread]