[Freeciv-Dev] Re: (PR#10359) Saving changes game state

["Marko Lindqvist" <cazfi74@xxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=10359 >

Marko Lindqvist wrote:
> 
> Marko Lindqvist wrote:
>> Marko Lindqvist wrote:
>>>   It seems that simply (auto)saving a game changes its state. Usually 
>>> this is difficult to notice - when you are not saving there is no save 
>>> games to compare.
>>   I'm reopening this ticket. Attached autogame has saveturns setting of 
>> 25. First autosave it produces is for year 2750 BC. If one changes 
>> saveturns setting to 1, it will produce different autosave for 2750 BC.
>>   Revision used 12145 trunk.
> 
>   Ahem. Saveturns setting itself is stored to savegame. Once I remove 
> saveturns from savegames, they start to differ at year 500.

  This (and #18825) must be because of bad memory access somewhere. 
Saving a game allocates and frees memory thus changing how things are 
arranged in memory. I managed to produce with saveturns = 25 identical 
500 AD savegame to one produced with saveturns = 1, when I made certain 
fc_malloc()/free() routines every turn.


  - ML