Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2006:
[Freeciv-Dev] Re: (PR#15840) common/dataio.c:700 is dubious 		Home

[Freeciv-Dev] Re: (PR#15840) common/dataio.c:700 is dubious

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#15840) common/dataio.c:700 is dubious
From: "Guillaume Melquiond" <guillaume.melquiond@xxxxxxxxx>
Date: Sun, 12 Mar 2006 16:10:10 -0800
Reply-to: bugs@xxxxxxxxxxx 
<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15840 >

On 3/13/06, Jason Short wrote:
>
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=15840 >
>
> I believe the previous bug was caused by endian issues.  A platform
> using 4-bit enumerations and an improper endianness will read the data
> incorrectly.

Indeed, I hadn't thought about endianness issues. Big-endian
architectures with shorter-than-int enumerations will serialize and
deserialize random values. My patch does fix this issue too.
[Prev in Thread] Current Thread [Next in Thread]