[Freeciv-Dev] (PR#15867) Client Exit if Metaserver Data Bad?

["Benedict Adamson" <badamson@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15867 >

I'm trying to run a modified version of SVN latest. The client exits if 
I try to connect to a network game, outputting the obscure message "0: 
Did not find token entry_name in (null) line 1". A stack trace at the 
moment of exit is as follows:

#0  0x406aa3d6 in exit () from /lib/tls/libc.so.6
#1  0x080a1071 in get_token (inf=0x8937da0, type=INF_TOK_ENTRY_NAME,
     required=true) at inputfile.c:613
#2  0x080a10b8 in inf_token_required (inf=0x8937da0, 
type=INF_TOK_ENTRY_NAME)
     at inputfile.c:625
#3  0x0809a06d in section_file_read_dup (sf=0xbfffd298, filename=0x0,
     inf=0x8937da0, allow_duplicates=true, requested_section=0x0)
     at registry.c:532
#4  0x0809a6d3 in section_file_load_from_stream (my_section_file=0xbfffd298,
     stream=0x8936d88) at registry.c:678
#5  0x080806e6 in parse_metaserver_data (f=0x8936d88) at servers.c:112
#6  0x08080ee2 in meta_read_response (scan=0x89361a0) at servers.c:379
#7  0x0808127e in get_metaserver_list (scan=0x89361a0) at servers.c:481
#8  0x08081dc3 in server_scan_get_servers (scan=0x89361a0) at servers.c:783
#9  0x0813fb6c in get_server_scan_list (data=0x0) at pages.c:351
#10 0x4060b8d6 in g_main_context_wakeup () from /usr/lib/libglib-2.0.so.0
#11 0x40609b8c in g_main_context_dispatch () from /usr/lib/libglib-2.0.so.0
#12 0x4060cf6b in g_main_context_check () from /usr/lib/libglib-2.0.so.0
#13 0x4060d2c7 in g_main_loop_run () from /usr/lib/libglib-2.0.so.0
#14 0x40151231 in gtk_main () from /usr/lib/libgtk-x11-2.0.so.0
#15 0x0812fdcb in ui_main (argc=1, argv=0xbffff8e4) at gui_main.c:1341
#16 0x08058e5b in main (argc=1, argv=0xbffff8e4) at civclient.c:380

I don't know what's going on here, but it seems that either the 
metaserver is producing faulty data or no metaserver data is available.

It seems that, if the meta-server data were ever faulty, no civclient 
would be able to connect to a network game: faulty meta-server code 
could DOS all Freeciv clients on the Internet! The client should degrade 
gracefully if the meta-server is unavailable or faulty.