[Freeciv-Dev] Re: (PR#15843) Editor: Fix fortress, paint city

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=15843 >

On Fri, 10 Mar 2006, Jason Short wrote:
> > This patch fixes two bugs in regards to fortresses. The first is that they
> > could be paintedas unowned, thus causing an assert failure in the borders
> > code. The second is that the assert failure is triggered even when borders
> > are not activated.
>
> Unowned fortresses should be allowed even when borders are activated.
> Scenarios could have unowned fortresses that players can rush to occupy.

Good point. I'll deal with this in a separate patch and ticket, though.

> > It also moves the city painting into the paint tab. You can now select
> > which player to paint as for cities and fortresses in the paint tab. The
> > city tab is removed.
>
> I don't see what advantage this really gives, but I suppose it doesn't
> hurt anything either.

The city tool had only one widget... It felt lonely. The fortress button
needed a player widget, so coupled them.

> > BTW, I noticed that you no longer can paint specials underneath cities.
> > Oops. My fault, I guess. I guess what happens when you click on a city
> > should be dependent on which tool you have selected?
>
> The behavior when you click on a city and you have a point tool open is
> that you should paint.This has nothing to do with which tool is selected.

Which tool should be selected for opening cities, then?

  - Per