[Freeciv-Dev] Re: (PR#13388) Server Crash on Load Saved Game

["White Raven" <whraven@xxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13388 >

> Your logic is correct but I'm not convinced it's not a bug that the
> connection isn't already detached.  Because if the connection is still
> attached here then we remove the conn list from the player but
> pconn->player still points at that player, meaning that now
> pconn->player is garbage.

That's what I was thinking when I made the comment about not knowing
whether the assertion should be removed or modified.  However, after
thinking about the state of the client, it seemed that you'd need to
detach, load the savegame, and reattach the client, and that didn't
sound likely.  I did look around for this sort of thing, but not knowing
the code as well as you guys, I figured it would be faster to try the
patch, which seemed to work fine, and someone more familiar with the
code would catch the implications.