[Freeciv-Dev] Re: (PR#13388) Server Crash on Load Saved Game

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13388 >

White Raven wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=13388 >
> 
> CVS version of 30 July, 2005, compiled for GTK-2.0.
> 
>>From the log file:
> 
> 
>>civserver: game.c:442: game_remove_player: Assertion 
>>`conn_list_size(pplayer->connections) == 0' failed.
> 
> 
> The assertion in game.c:
> 
> assert(conn_list_size(pplayer->connections) == 0);
> 
> is not true when the client requests the load of a savegame; there is,
> in fact, at least one client connection.  The server crashes, and the
> savegame cannot be loaded.  The patch below appears to fix the crash
> without causing other serious problems.  Without knowing why the
> assertion was there in the first place, I'm not sure whether it should
> be removed (as this patch does), or modified.

Your logic is correct but I'm not convinced it's not a bug that the
connection isn't already detached.  Because if the connection is still
attached here then we remove the conn list from the player but
pconn->player still points at that player, meaning that now
pconn->player is garbage.

-jason