[Freeciv-Dev] (PR#13252) Research and teams

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=13252 >

I think each team - and each research struct if the research isn't part
of the team - should have its own player list.  That would make it easy
to iterate over the players who share the team or research, and allow
more types of sanity checking.

It is possible to move the research struct into the team struct.  The
way we have it now all teams share research so there's no reason not to
do this.  The reason we wouldn't want to do this however is if we wanted
team research to be optional.  It would be pretty easy with the current
setup to make this a pregame server setting, and then have players'
research structs merged or split as needed.  Another issue is that
players may theoretically be able to have a NULL team - I don't think
this is possible now but to be safe I wrote the code to deal with it if
it happens.  This would be most likely to happen for barbarians or
observers, who can't research anyway - so maybe not having a research
struct would be a feature.

-jason