Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2005:
[Freeciv-Dev] Re: (PR#12852) Major bug: AI ignores skill-level directive 		Home

[Freeciv-Dev] Re: (PR#12852) Major bug: AI ignores skill-level directive

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
Subject: [Freeciv-Dev] Re: (PR#12852) Major bug: AI ignores skill-level directives
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 20 Apr 2005 09:15:11 -0700
Reply-to: bugs@xxxxxxxxxxx 
<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12852 >

Per I. Mathisen wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12852 >
> 
> On Tue, 19 Apr 2005, Jason Short wrote:
> 
>>This patch should fix it, more or less.A better fix may be possible.
> 
> 
> -    int want = pcity->ai.settler_want;
> +    int want = pcity->ai.settler_want * pplayer->ai.expand;
> 
> Surely it should be:
> 
> +    int want = pcity->ai.settler_want * pplayer->ai.expand / 100;

Surely.

I also kindof think the multiplication should be done inside settlers.c
when the settler_want is calculated, rather than in all the places it is
used (which is currently just one however).

-jason
[Prev in Thread] Current Thread [Next in Thread]