[Freeciv-Dev] (PR#9172) RFC: Choose nations in pregame

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=9172 >

Here's my idea for how this should be done.

First of all this should probably wait until the new-start behavior is
finished (PR#12838).  Although that shouldn't take too long I hope...

When a player is created (through a user connecting, or /create), the
should be assigned a nation and leader.  The default should be 'random'
for both (a placeholder to indicate a random assignment at /start time).

This should be sent to the clients and shown for all players in the
mini-players dialog.  At least the nation should be shown; the leader
may not be necessary.

The client startscreen should have a "change nation" button which pops
up the same nations dialog we have now.  This dialog is non-modal and
when the player chooses their nation+leader this info is sent to the
server.  Hence the player can change his nation multiple times, etc.

For controller connections, there should be one such button *per
player*, or maybe for AI players.  Thus you can assign the nation of
someone other than yourself (if you have permissions), and assign the
nation of an AI player.

When the game starts any unassigned players are given nations at random.

-jason