Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2005:
[Freeciv-Dev] (PR#12034) gtk2 startscreen: not clear when you're connect
Home

[Freeciv-Dev] (PR#12034) gtk2 startscreen: not clear when you're connect

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#12034) gtk2 startscreen: not clear when you're connecting
From: "Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>
Date: Sun, 10 Apr 2005 13:32:01 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12034 >

> [jdorje - Fri Jan 28 05:54:01 2005]:
> 
> I boot up the client and try to connect to the server.  I click connect.
> 
> The server's running under valgrind and loading a large game, so there's 
> no response for a while.  This makes the problem quite obvious...that 
> clicking "OK" (why is it called "OK" not "connect"?) has no immedate 
> result.  If I click it again I get a "connection in progress"
notification.
> 
> On the first click the text should be changed to "Connecting...".

Here is a patch which renames the button. Since it changes strings, it
will only go on HEAD.

Index: client/gui-gtk-2.0/pages.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/gui-gtk-2.0/pages.c,v
retrieving revision 1.23
diff -u -u -r1.23 pages.c
--- client/gui-gtk-2.0/pages.c  28 Mar 2005 16:59:14 -0000      1.23
+++ client/gui-gtk-2.0/pages.c  10 Apr 2005 20:31:21 -0000
@@ -851,7 +851,7 @@
   g_signal_connect(button, "clicked",
       G_CALLBACK(main_callback), NULL);
 
-  button = gtk_button_new_from_stock(GTK_STOCK_OK);
+  button = gtk_button_new_with_mnemonic(_("C_onnect"));
   gtk_container_add(GTK_CONTAINER(bbox), button);
   g_signal_connect(button, "clicked",
       G_CALLBACK(connect_callback), NULL);

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#12034) gtk2 startscreen: not clear when you're connecting, Vasco Alexandre da Silva Costa <=