Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2005:
[Freeciv-Dev] Re: (PR#12756) Improving error message in inputfile
Home

[Freeciv-Dev] Re: (PR#12756) Improving error message in inputfile

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: per@xxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#12756) Improving error message in inputfile
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 10 Apr 2005 10:14:36 -0700
Reply-to: bugs@xxxxxxxxxxx

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12756 >

Per I. Mathisen wrote:
> <URL: http://bugs.freeciv.org/Ticket/Display.html?id=12756 >
> 
> On Sun, 10 Apr 2005, Jason Short wrote:
> 
>>Per I. Mathisen wrote:
>>
>>><URL: http://bugs.freeciv.org/Ticket/Display.html?id=12756 >
>>>
>>>"1: Did not find required token: entry_name"
>>>
>>>Patch changes this to the more helpful:
>>>
>>>"1: Did not find token entry_name in data/default/effects.ruleset line 71"
>>>
>>>Now it is possible to make a mistake in a ruleset without tearing your
>>>hair out.
>>
>>Why is the "return NULL" condition removed?
> 
> It isn't. Just read the context...

Sorry, I was looking only at the first patch.  The second one looks fine 
- although you may want to leave in the LOG_DEBUG message for !required 
entries.

-jason





[Prev in Thread] Current Thread [Next in Thread]