[Freeciv-Dev] Re: (PR#12725) Attacking Ferries and ai_fill_unit_param

["Benedict Adamson" <badamson@xxxxxxxxxxx>]

<URL: http://bugs.freeciv.org/Ticket/Display.html?id=12725 >

Benedict Adamson wrote:
...
> The combination of the new PF AI goto code...
> and my update of the ancients rule-set crashes in PF with the 
> attached autogame.
> 
> The crash is because of the following assertion fails:
> path_finding.c:799:
...
> the set up of the PF parameters by the new 
> ai_fill_unit_param function mishandles such cases when punit->ai.ai_role 
> == AIUNIT_ATTACK... I don't know
> if that is the cause of the crash, but it's certainly a bug.
...

It seems that it is not the cause of the bug: I made a fix to 
ai_fill_unit_param, but PF crashes in the same place for a different 
unit. I'm opening a separate PR for the PF problem, keeping this PR for 
the ai_fill_unit_param problem.